fix: read from response body in DownloadArtifact#376
Open
Manar-Elhabbal7 wants to merge 1 commit into
Open
Conversation
Manar-Elhabbal7
requested review from
Harsh4902,
lbroudoux and
yada
as code owners
Signed-off-by: Manar Elhabbal <manarelhabbal619@gmail.com>
Manar-Elhabbal7
force-pushed
the
fix-artifact-download
branch
from
8c2686a to
0ade8bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using import-url, the CLI was showing an empty message:
Microcks has discovered ''.
This happened because the code was reading the response from the wrong place (req.Body instead of resp.Body), so it couldn’t get the server message
before solving it :
after solving it
Related issue(s) #375