test: use temporary config file in context delete test#334
Open
hazelmayank wants to merge 1 commit into
Open
Conversation
Signed-off-by: hazelmayank <mayankjeefinal@gmail.com>
hazelmayank
force-pushed
the
test/use-tempdir-context-delete
branch
from
694b255 to
2e9fe1c
Compare
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
TestDeleteContextby updating it to use a temporary config file created witht.TempDir()instead of writing to./testdata/local.config.On a clean checkout,
cmd/testdatamay not exist, which causes the test to fail with:open ./testdata/local.config: no such file or directory
The test behavior remains unchanged, but it no longer depends on an untracked local directory.
Fixes #313
Related to #321
Test plan
go test ./cmd/... -run TestDeleteContext -v
go test ./...
go test ./cmd/... -count=3
make build-local