[WC-3390] DG2: improve virtual scroll behavior and height logic#2193
Open
[WC-3390] DG2: improve virtual scroll behavior and height logic#2193
Conversation
yordan-st
force-pushed
the
fix/WC-3390_virtual-scroll-bug
branch
5 times, most recently
from
28d92e3 to
a3e363f
Compare
iobuhov
reviewed
Apr 30, 2026
| [gridSizeStore] | ||
| ); | ||
|
|
||
| useEffect(() => { |
Collaborator
There was a problem hiding this comment.
This use effect runs on every rerender. That's by design?
Collaborator
There was a problem hiding this comment.
Maybe this should be fixed in GridSizeStore?
Contributor
Author
There was a problem hiding this comment.
The no-dep-array was pre-existing. But I moved new logic to GridSizeStore
yordan-st
force-pushed
the
fix/WC-3390_virtual-scroll-bug
branch
from
f72a5e8 to
6a14738
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description