[WC-3297] Signature web#2138

Open

gjulivan wants to merge 8 commits intomainfrom

Collaborator

gjulivan commented Mar 16, 2026

Pull request type

Description

gjulivan requested a review from a team as a code owner

March 16, 2026 13:14

github-actions Bot added the signature-web label

gjulivan changed the title ~~Signature web~~ [WC-3297] Signature web

gjulivan force-pushed the signature-web branch from ebcf9cc to b0d9476 Compare

March 16, 2026 13:14

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/__tests__/AppEvents.spec.tsx Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/components/Alert.tsx Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/assets/Signature.icon.dark.svg

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/ui/SignaturePreview.css Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/assets/Signature.icon.dark.png Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/package.xml Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/Signature.editorConfig.ts Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/Signature.tsx Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/CHANGELOG.md

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/package.json Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/package.json

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/package.json Outdated

gjulivan force-pushed the signature-web branch 8 times, most recently from 1edd154 to c439717 Compare

March 26, 2026 08:45

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/components/Signature.tsx

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/README.md Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/package.json Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/package.json Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/mendix-pluggable-widgets-tools.tgz Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/Signature.xml Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/utils/customTypes.ts

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/utils/useResizeObserver.ts Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/utils/useSignaturePad.ts Outdated

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/utils/Utils.ts

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/Signature.tsx Outdated

gjulivan force-pushed the signature-web branch 7 times, most recently from f4f70c2 to bafb254 Compare

March 27, 2026 11:57

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/components/SizeContainer.ts Outdated

gjulivan force-pushed the signature-web branch from bafb254 to 61f25b4 Compare

April 21, 2026 08:05

gjulivan added 8 commits

April 21, 2026 12:26


          feat(signature): initial version of signature web widget

e1c84cb


          feat(signature): refactoring and rearrange codes

c0a1c6c


          chore: update signature widget

fd3c4bb


          fix: add unit test

8c4a760


          fix: update icons and code cleanup

3fed1a6


          fix: snapshot and test

fff47e3


          chore: update props and code cleanup

bd1c385


          fix: convert size container into jsx and add filename property

d15e0e3

gjulivan force-pushed the signature-web branch from e84f8ad to d15e0e3 Compare

April 21, 2026 10:26

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/components/SizeContainer.tsx

Comment on lines +19 to +43

+                  return (
+                      <div
+                          ref={ref}
+                          className={classNames(className, "size-box")}
+                          style={{
+                              position: "relative",
+                              ...wrapperStyle,
+                              ...style
+                          }}
+                      >
+                          <div
+                              className={classNames("size-box-inner", classNameInner)}
+                              aria-disabled={readOnly}
+                              style={{
+                                  position: "absolute",
+                                  top: 0,
+                                  right: 0,
+                                  bottom: 0,
+                                  left: 0
+                              }}
+                          >
+                              {children}
+                          </div>
+                      </div>
+                  );

Collaborator

iobuhov Apr 30, 2026

Let's move all inline styles to sass files.

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/utils/useSignaturePad.ts

+              import SignaturePad, { Options } from "signature_pad";
+              import { SignatureProps } from "./customTypes";
+              function usePrevious<T>(value: T): T | null {

Collaborator

iobuhov Apr 30, 2026

I don't understand why we need this hook. Why we need keep attribute in ref and use effect to update it?

iobuhov reviewed

View reviewed changes

packages/pluggableWidgets/signature-web/src/utils/dimensions.ts

Collaborator

iobuhov Apr 30, 2026

I think this is duplicate of tools we have in 'platform' plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels