Draft
Conversation
0db0b8d to
3f6cc95
Compare
3f6cc95 to
cfb06c8
Compare
cfb06c8 to
ea07257
Compare
agontard
reviewed
Apr 19, 2026
Member
|
Hi, |
Member
Author
|
Note that the "generalization" to It was not there originally. |
Member
Author
|
So, in other words, I do not think that it was meant to correspond the "type of ring for which the property of being an integer is decidable". Shall we however PR the latter to MathComp? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
@agontard : what do you think about this change?
We do not use it a lot in MathComp-Analysis per se, as a user, we'd like your opinion.
TODO: introduce "type of ring for which the property of being an integer is decidable" and refactor, even though we do not have a use for it now, this could be a useful addition to MathComp
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers