Skip to content

tentative removal of Rint#1937

Draft
affeldt-aist wants to merge 2 commits intomath-comp:masterfrom
affeldt-aist:reals_20260417
Draft

tentative removal of Rint#1937
affeldt-aist wants to merge 2 commits intomath-comp:masterfrom
affeldt-aist:reals_20260417

Conversation

@affeldt-aist
Copy link
Copy Markdown
Member

@affeldt-aist affeldt-aist commented Apr 16, 2026

Motivation for this change

@agontard : what do you think about this change?
We do not use it a lot in MathComp-Analysis per se, as a user, we'd like your opinion.

TODO: introduce "type of ring for which the property of being an integer is decidable" and refactor, even though we do not have a use for it now, this could be a useful addition to MathComp

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@affeldt-aist affeldt-aist added the experiment 🧪 This issue/PR is very experimental label Apr 16, 2026
@affeldt-aist affeldt-aist marked this pull request as draft April 16, 2026 23:45
@affeldt-aist affeldt-aist added this to the 1.17.0 milestone Apr 19, 2026
@affeldt-aist affeldt-aist marked this pull request as ready for review April 19, 2026 14:58
@affeldt-aist affeldt-aist requested review from amahboubi and strub April 19, 2026 15:03
Comment thread CHANGELOG_UNRELEASED.md Outdated
@CohenCyril
Copy link
Copy Markdown
Member

Hi, Rint was using classical logic to exhibit integers in any realFieldType, while Num.int requires Archimedeanity, therefore they are incomparable, and with this PR you eliminate expressivity -- albeit apparently not used according to the CI. The proper way to refactor this would be to introduce the "type of ring for which the property of being an integer is decidable".

@affeldt-aist
Copy link
Copy Markdown
Member Author

Note that the "generalization" to realFieldType was carried out some time ago
ef24876#diff-db2a60c8905528789fdebb5e121d48be6e89590ae44cfcdd26e1b037660707e0

It was not there originally.

@affeldt-aist
Copy link
Copy Markdown
Member Author

So, in other words, I do not think that it was meant to correspond the "type of ring for which the property of being an integer is decidable". Shall we however PR the latter to MathComp?

@affeldt-aist affeldt-aist marked this pull request as draft April 21, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experiment 🧪 This issue/PR is very experimental

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants