Conversation
Nokogiri is already in our dependency tree, so might as well use it instead. Faraday is already in our dependency tree, so might as well use it.
Collaborator
Author
https://rubygems.org/gems/activesupport/versions/8.1.3 
|
3.2 is working on my machine. activesupport 8.1.3 has a minimum Ruby version of 3.2, so that's probably the bundle install problem in CI right now.
Collaborator
Author
|
OK. I see a problem now ... |
Also, fix URI.escape going away. Use Addressable::URI.escape instead. (Already a transitive dependency.) Also also, open() -> http_get() in a few places I missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nokogiri is already in our dependency tree, so might as well use it instead.
Faraday is already in our dependency tree, so might as well use it.