Redirect CGameRulesProxy to CGameRules in CScriptNetPropManager#535
Open
azzyr wants to merge 1 commit into
Open
Redirect CGameRulesProxy to CGameRules in CScriptNetPropManager#535azzyr wants to merge 1 commit into
azzyr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes CScriptNetPropManager handle GameRules proxy entities by redirecting networked property access from CGameRulesProxy to the underlying CGameRules object
This matches TF2 SDK behavior and fixes GetProp/SetProp methods returning 0 for gamerules properties
NetProps.GetPropInt(Entities.FindByClassname(null, "tf_gamerules"), "m_iRoundState")Does this PR close any issues?
PR Checklist
developbranch OR targets another branch with a specific goal in mind