You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
"Hi mate, I extended the recorder to support Per-Application isolated recording via WASAPI loopback (so you can record Discord without recording game sound). Here is the code if you want to merge it."
Hi @RangeyRover, thanks for this. Per-app recording via WASAPI loopback is a cool addition!
Before I dive into the review, a few things I want to clarify with you:
UX: how does a user select the target app? Is it a new dropdown in the settings, does it replace "System Audio" mode, or does it sit alongside it? A screenshot or short clip of the new UI would help a lot.
Fallback: what happens on Windows versions where the per-app loopback API isn't available (pre Windows 10 2004, I think)? Does it fail gracefully or crash?
Testing: what did you test this against? Just Discord, or multiple apps? Any weirdness with apps that change their audio session (e.g. browsers switching tabs)?
I'll also want to test it locally before merging, so give me a few days on that.
Also: I just added a CONTRIBUTING.md to the repo, nothing you did wrong, just putting it in place for future PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Hi mate, I extended the recorder to support Per-Application isolated recording via WASAPI loopback (so you can record Discord without recording game sound). Here is the code if you want to merge it."