[top,sw/dv] Clk pwr rst smoke tests#460
Open
csabakiss-semify wants to merge 4 commits intolowRISC:mainfrom
Open
[top,sw/dv] Clk pwr rst smoke tests#460csabakiss-semify wants to merge 4 commits intolowRISC:mainfrom
csabakiss-semify wants to merge 4 commits intolowRISC:mainfrom
Conversation
Signed-off-by: Csaba Kiss <csaba.kiss@semify-eda.com>
Signed-off-by: Csaba Kiss <csaba.kiss@semify-eda.com>
csabakiss-semify
force-pushed
the
clk_pwr_rst_smoke_test
branch
from
8f4c502 to
2dbcd22
Compare
Signed-off-by: Csaba Kiss <csaba.kiss@semify-eda.com>
csabakiss-semify
force-pushed
the
clk_pwr_rst_smoke_test
branch
from
2dbcd22 to
7adf270
Compare
…ests to top level smoke regression and top level sim config Signed-off-by: Csaba Kiss <csaba.kiss@semify-eda.com>
martin-velay
changed the title
Collaborator
marnovandermaas
left a comment
marnovandermaas
left a comment
There was a problem hiding this comment.
Some initial comments from my end.
|
|
||
| if (rstmgr_software_reset_info_get(rstmgr)) { | ||
| return true; | ||
| if (reason & RSTMGR_RESET_INFO_POR) { |
Collaborator
There was a problem hiding this comment.
Nice, this is a good change!
| DEV_WRITE(rstmgr + RSTMGR_RESET_REQ_REG, RSTMGR_RESET_REQ_TRUE); | ||
| } | ||
|
|
||
| bool rstmgr_software_reset_info_get(rstmgr_t rstmgr) |
Collaborator
There was a problem hiding this comment.
I think we can now remove this function. I think it was only used in the software_reset test.
Comment on lines
+11
to
+25
| static uint32_t clkmgr_read(clkmgr_t clkmgr, uintptr_t reg) | ||
| { | ||
| return DEV_READ(clkmgr + reg); | ||
| } | ||
|
|
||
| static void clkmgr_write(clkmgr_t clkmgr, uintptr_t reg, uint32_t value) | ||
| { | ||
| DEV_WRITE(clkmgr + reg, value); | ||
| } | ||
|
|
||
| static uint32_t clkmgr_bit(size_t clock) | ||
| { | ||
| return 1u << clock; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
These don't look like clock manager specific functions. Do they already exist elsewhere in the repo?
| bool toggled = !initial; | ||
|
|
||
| clkmgr_gateable_clock_set_enabled(clkmgr, CLKMGR_GATEABLE_CLOCK_IO_PERI, toggled); | ||
| if (clkmgr_gateable_clock_get_enabled(clkmgr, CLKMGR_GATEABLE_CLOCK_IO_PERI) != toggled) { |
Collaborator
There was a problem hiding this comment.
Is there any way that we can confirm that the peripherals are actually stopped? I'm not sure whether reading a register will cause a bus error or just hang the design.
| pwrmgr_t mocha_system_pwrmgr(void) | ||
| { | ||
| #if defined(__riscv_zcherihybrid) | ||
| return (pwrmgr_t)create_mmio_capability(pwrmgr_base, 0x80u); |
Collaborator
There was a problem hiding this comment.
I think this length can be 0x44
Comment on lines
+9
to
+22
| static uint32_t pwrmgr_read(pwrmgr_t pwrmgr, uintptr_t reg) | ||
| { | ||
| return DEV_READ(pwrmgr + reg); | ||
| } | ||
|
|
||
| static void pwrmgr_write(pwrmgr_t pwrmgr, uintptr_t reg, uint32_t value) | ||
| { | ||
| DEV_WRITE(pwrmgr + reg, value); | ||
| } | ||
|
|
||
| uint32_t pwrmgr_control_get(pwrmgr_t pwrmgr) | ||
| { | ||
| return pwrmgr_read(pwrmgr, PWRMGR_CONTROL_REG); | ||
| } |
Collaborator
There was a problem hiding this comment.
Replicated from clock manager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can see the conflicts, even if I just finished the rebase. However, I am opening this PR to start the review process. I will fix the further conflicts just before the merge.