Draft
Conversation
gtsiolis
requested review from
anisaoshafi,
carole-lavillonniere and
silv-io
as code owners
Collaborator
|
I would like to rework this because here we spin up two sequential TUI: one for login, then exit, and new TUI for start. That's not following the existing pattern (one TUI per command) and is a bit surprising. |
carole-lavillonniere
force-pushed
the
des-208-move-header-after-auth-flow-on-first-run
branch
from
20fb41d to
c181cee
Compare
carole-lavillonniere
force-pushed
the
des-208-move-header-after-auth-flow-on-first-run
branch
from
c181cee to
4dc7387
Compare
gtsiolis
commented
Apr 29, 2026
Member
Author
There was a problem hiding this comment.
I'd expect the header to be injected in a linear way after the authentication is complete. Now the header is injected above the welcome message when the authentication completes which reminds me of layout shift in browsers.
| Before authentication | After authentication |
|---|---|
 |
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On first interactive run with no auth token, run the device-flow login before launching the start UI so the header doesn't render with (No license) while authentication is still pending. This will hide the banner during the login flow and render the header after login succeeds and the start UI takes over with a resolved license label.