Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion livekit-rtc/jupyter-html/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"@eslint/js": "^9.39.3",
"@types/react": "^19.2.14",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^4.7.0",
"@vitejs/plugin-react": "^6.0.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Peer dependency mismatch: @vitejs/plugin-react@6 requires vite ^8.0.0 but project uses vite ^6.4.1

The @vitejs/plugin-react was bumped from ^4.7.0 to ^6.0.0, which resolves to v6.0.1. However, this version declares a peer dependency of vite: ^8.0.0 (visible in the pnpm-lock.yaml), while the project's package.json:30 still specifies vite: ^6.4.1 (resolved to 6.4.2). This peer dependency mismatch means the plugin is not tested or guaranteed to work with vite 6, and could cause build failures or subtle runtime issues. The vite dependency should also be bumped to ^8.0.0 to match, or @vitejs/plugin-react should be kept at a version compatible with vite 6.

Prompt for agents
The @vitejs/plugin-react was bumped from ^4.7.0 to ^6.0.0, but @vitejs/plugin-react@6.x declares a peer dependency of vite: ^8.0.0. The project still uses vite: ^6.4.1 on line 30 of package.json. Either:
1. Also bump vite to ^8.0.0 (and verify all other vite plugins like vite-plugin-singlefile are compatible with vite 8), OR
2. Keep @vitejs/plugin-react at a version compatible with vite 6 (e.g., ^4.7.0 or whichever major version supports vite 6).

The pnpm-lock.yaml confirms the mismatch: @vitejs/plugin-react@6.0.1 lists peerDependencies vite: ^8.0.0 but resolves with vite@6.4.2.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"eslint": "^9.39.3",
"eslint-plugin-react-hooks": "^5.2.0",
"eslint-plugin-react-refresh": "^0.4.26",
Expand Down
Loading
Loading