Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript ✅ grid-python studio · code
✅ grid-kotlin studio · code
✅ grid-typescript studio · code
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
Greptile SummaryThis auto-synced PR updates IBAN field definitions for three currencies (DKK, EGP, PKR) from a generic IBAN pattern to country-specific patterns, lengths, examples, and descriptions across the source schemas and the regenerated bundle files. The source YAML files in Confidence Score: 5/5This PR is safe to merge — schema changes are correct, consistent, and follow the expected build workflow. All three country-specific IBAN patterns are technically accurate, their examples validate against the new patterns, min/max lengths match the fixed character counts, and the generated bundle files are consistent with the source schemas. No logic, syntax, or security issues found. No files require special attention.
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/common/DkkAccountInfoBase.yaml | IBAN updated to DK-specific: 18-char fixed length, pattern ^DK[0-9]{16}$, example and description corrected. Pattern and example are consistent. |
| openapi/components/schemas/common/EgpAccountInfoBase.yaml | IBAN updated to EG-specific: 29-char fixed length, pattern ^EG[0-9]{27}$, example and description corrected. Pattern and example are consistent. |
| openapi/components/schemas/common/PkrAccountInfoBase.yaml | IBAN updated to PK-specific: 24-char fixed length, pattern ^PK[0-9]{2}[A-Z]{4}[0-9]{16}$, example and description corrected. Pattern and example are consistent. |
| openapi.yaml | Generated bundle updated to reflect all three IBAN schema changes; content is consistent with source YAML files. |
| mintlify/openapi.yaml | Mintlify bundle updated to reflect all three IBAN schema changes; identical to root openapi.yaml for the changed sections. |
Entity Relationship Diagram
%%{init: {'theme': 'neutral'}}%%
erDiagram
DkkAccountInfoBase {
string accountType "enum: DKK_ACCOUNT"
string iban "^DK[0-9]{16}$ len=18"
string swiftCode "8-11 chars BIC"
}
EgpAccountInfoBase {
string accountType "enum: EGP_ACCOUNT"
string bankName "1-255 chars"
string accountNumber "1-34 chars"
string iban "^EG[0-9]{27}$ len=29"
string swiftCode "8-11 chars BIC"
}
PkrAccountInfoBase {
string accountType "enum: PKR_ACCOUNT"
string bankName "1-255 chars"
string accountNumber "1-34 chars"
string iban "^PK[0-9]{2}[A-Z]{4}[0-9]{16}$ len=24"
string phoneNumber "+E.164 format"
}
Reviews (1): Last reviewed commit: "chore: Sync account schemas" | Re-trigger Greptile
Auto-synced account schemas.
These schemas are generated from VASP adapter field definitions in sparkcore.
Synced schemas:
common/— per-currency account info, beneficiary, and payment account schemascommon/PaymentInstructions.yaml— payment instructions oneOf (new currencies added)external_accounts/— per-currency external account schemas (reference common/)Please review the changes before merging.