Skip to content

chore: Sync account schemas#406

Merged
jklein24 merged 1 commit intomainfrom
auto/sync-grid-schemas-20260428-004831
Apr 28, 2026
Merged

chore: Sync account schemas#406
jklein24 merged 1 commit intomainfrom
auto/sync-grid-schemas-20260428-004831

Conversation

@lightspark-copybara
Copy link
Copy Markdown
Contributor

Auto-synced account schemas.

These schemas are generated from VASP adapter field definitions in sparkcore.

Synced schemas:

  • common/ — per-currency account info, beneficiary, and payment account schemas
  • common/PaymentInstructions.yaml — payment instructions oneOf (new currencies added)
  • external_accounts/ — per-currency external account schemas (reference common/)

Please review the changes before merging.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview, Comment Apr 28, 2026 0:49am

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

✱ Stainless preview builds

This PR will update the grid SDKs with the following commit messages.

kotlin

docs(types): update IBAN field descriptions in DKK/EGP/PKR account models

openapi

fix(types): correct IBAN validation patterns in DKK/EGP/PKR account models

python

docs(types): update IBAN field descriptions for DKK/EGP/PKR account models

typescript

docs(types): update IBAN field descriptions for DKK/EGP/PKR account types
grid-openapi studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅

grid-python studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅build ✅lint ✅test ✅

pip install https://pkg.stainless.com/s/grid-python/4363bf7ea38fe066e8f3454364e42f216cf12679/grid-0.0.1-py3-none-any.whl
grid-kotlin studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅build ✅lint ✅test ✅

grid-typescript studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅build ✅lint ✅test ✅

npm install https://pkg.stainless.com/s/grid-typescript/b16d93202fd0d1cc07bbd1bb5962234ae1abff81/dist.tar.gz

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-04-28 05:46:37 UTC

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 28, 2026

Greptile Summary

This auto-synced PR updates IBAN field definitions for three currencies (DKK, EGP, PKR) from a generic IBAN pattern to country-specific patterns, lengths, examples, and descriptions across the source schemas and the regenerated bundle files. The source YAML files in openapi/components/schemas/common/ were correctly modified first, and openapi.yaml/mintlify/openapi.yaml appear to have been regenerated via make build, consistent with the workflow described in CLAUDE.md.

Confidence Score: 5/5

This PR is safe to merge — schema changes are correct, consistent, and follow the expected build workflow.

All three country-specific IBAN patterns are technically accurate, their examples validate against the new patterns, min/max lengths match the fixed character counts, and the generated bundle files are consistent with the source schemas. No logic, syntax, or security issues found.

No files require special attention.

Important Files Changed

Filename Overview
openapi/components/schemas/common/DkkAccountInfoBase.yaml IBAN updated to DK-specific: 18-char fixed length, pattern ^DK[0-9]{16}$, example and description corrected. Pattern and example are consistent.
openapi/components/schemas/common/EgpAccountInfoBase.yaml IBAN updated to EG-specific: 29-char fixed length, pattern ^EG[0-9]{27}$, example and description corrected. Pattern and example are consistent.
openapi/components/schemas/common/PkrAccountInfoBase.yaml IBAN updated to PK-specific: 24-char fixed length, pattern ^PK[0-9]{2}[A-Z]{4}[0-9]{16}$, example and description corrected. Pattern and example are consistent.
openapi.yaml Generated bundle updated to reflect all three IBAN schema changes; content is consistent with source YAML files.
mintlify/openapi.yaml Mintlify bundle updated to reflect all three IBAN schema changes; identical to root openapi.yaml for the changed sections.

Entity Relationship Diagram

%%{init: {'theme': 'neutral'}}%%
erDiagram
    DkkAccountInfoBase {
        string accountType "enum: DKK_ACCOUNT"
        string iban "^DK[0-9]{16}$ len=18"
        string swiftCode "8-11 chars BIC"
    }
    EgpAccountInfoBase {
        string accountType "enum: EGP_ACCOUNT"
        string bankName "1-255 chars"
        string accountNumber "1-34 chars"
        string iban "^EG[0-9]{27}$ len=29"
        string swiftCode "8-11 chars BIC"
    }
    PkrAccountInfoBase {
        string accountType "enum: PKR_ACCOUNT"
        string bankName "1-255 chars"
        string accountNumber "1-34 chars"
        string iban "^PK[0-9]{2}[A-Z]{4}[0-9]{16}$ len=24"
        string phoneNumber "+E.164 format"
    }
Loading

Reviews (1): Last reviewed commit: "chore: Sync account schemas" | Re-trigger Greptile

@jklein24 jklein24 merged commit 22b187a into main Apr 28, 2026
8 checks passed
@jklein24 jklein24 deleted the auto/sync-grid-schemas-20260428-004831 branch April 28, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant