EFM32 - change bitfield definitions to be unshifted.#595
Closed
kbob wants to merge 5 commits intolibopencm3:masterfrom
Closed
EFM32 - change bitfield definitions to be unshifted.#595kbob wants to merge 5 commits intolibopencm3:masterfrom
kbob wants to merge 5 commits intolibopencm3:masterfrom
Conversation
Contributor
Author
|
The libopencm3-examples pull request is #116. |
Contributor
There was a problem hiding this comment.
When you are #defining simply a number do you really need parenthesis around it?
Contributor
|
other than the admittedly harmless extra parenthsis it looks good to me @kbob |
Contributor
Author
|
I removed the parentheses. |
Contributor
Author
|
This is superceded by #606. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change all bitfield constant definitions for EFM32 to use unshifted values. Also fixed three errata in the definitions.
I also have an update for libopencm3-examples pull request #85 that uses the updated definitions. I will submit a pull request for that momentarily.
Rationale
In the comments on Pull Request #581, @karlp and @ChuckM asked that the bitfield definitions be unshifted. E.g., instead of
this is the preferred way.