fix: prevent private default instances from leaking into public scope#13596
Open
Kha wants to merge 1 commit intoleanprover:masterfrom
Open
fix: prevent private default instances from leaking into public scope#13596Kha wants to merge 1 commit intoleanprover:masterfrom
Kha wants to merge 1 commit intoleanprover:masterfrom
Conversation
…oration This PR fixes elaboration of expressions in public scope when a `@[default_instance]` is reachable only through a private `import`: such defaults are now skipped during default-instance synthesis instead of being tried and failing with `Unknown constant ...`, parallel to how regular instances are already filtered. Implementation: `getDefaultInstances` now drops candidates whose constant is not publicly visible whenever `env.isExporting`, mirroring the filter in `Lean.Meta.SynthInstance.getInstances`. The `defaultInstanceExtension` also gains an `exportEntriesFnEx?` to drop entries with private names from the exported/server olean levels, parallel to the filter on `instanceExtension`.
github-actions
Bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
github-actions
Bot
added
the
mathlib4-nightly-available
mathlib-lean-pr-testing
Bot
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes private(ly imported) default instances from accidentally being used in public signatures, leading to follow-up errors.
As reported at https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/Elaboration.20of.20heterogeneous.20mul.20with.20the.20module.20system