Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of Lua function return values as C++ tuples and adds a new test case to verify support for tuples containing
LuaRefobjects. The main change refactors how tuple results are decoded from the Lua stack to be more robust and efficient.Tuple result decoding improvements:
decode_tuple_resultinInvoke.hto first collect all stack elements into a tuple ofstd::optionalvalues, then check for errors and construct the result tuple in a single step. This streamlines error handling and avoids partially constructed tuples.Testing enhancements:
CallReturningTupleWithLuaRefinLuaRefTests.cppto verify that Lua functions returning a tuple with a table (as aLuaRef) are correctly handled, including checking table contents.