subcommand: add new subsystem/subcommand - storage#274
Open
nuclearcat wants to merge 2 commits intokernelci:mainfrom
Open
subcommand: add new subsystem/subcommand - storage#274nuclearcat wants to merge 2 commits intokernelci:mainfrom
nuclearcat wants to merge 2 commits intokernelci:mainfrom
Conversation
Add new subcommand to use KernelCI storage. Useful to store logs, artifacts and etc. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
tales-aparecida
approved these changes
Apr 30, 2026
tales-aparecida
left a comment
tales-aparecida
left a comment
There was a problem hiding this comment.
LGTM
Could do with a bit of "assert_called_once_with" smoke testing, to ensuring the cli args are being forwarded as expected
Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
Member
|
looks like black check is failing, can you fix the black formatting issues? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new subcommand to use KernelCI storage.
Useful to store logs, artifacts and etc.
Example: kci-dev --instance=staging storage checkauth