fix(tests): guard disk-based search test with SEARCH_TEST_LOCK#12
Merged
fix(tests): guard disk-based search test with SEARCH_TEST_LOCK#12
Conversation
…hans + simplify self-references test_sync_index_to_db_removes_orphans operates on disk-based Tantivy index (unlike with_temp_index which uses RAM index). Without SEARCH_TEST_LOCK it may race with other search tests on Windows mmap handle lifecycle. - Add SEARCH_TEST_LOCK guard to test_sync_index_to_db_removes_orphans - Simplify crate::search::self-references in test to direct calls - Zero functional code changes 验证: cargo check 0 errors; clippy 0 warnings; cargo test --workspace 503 passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
防御性修复 flaky tests：
验证: cargo check 0 errors; clippy 0 warnings; test 503 passed / 0 failed