Skip to content

Bugfix for issue #396 - Performance issue because of PathNotFoundException#398

Open
jzarnikov wants to merge 2 commits intojson-path:masterfrom
jzarnikov:master
Open

Bugfix for issue #396 - Performance issue because of PathNotFoundException#398
jzarnikov wants to merge 2 commits intojson-path:masterfrom
jzarnikov:master

Conversation

@jzarnikov
Copy link
Copy Markdown

No description provided.

@jzarnikov
Copy link
Copy Markdown
Author

Not sure why travis-ci fails:

ERROR: JAVA_HOME is set to an invalid directory: /usr/lib/jvm/java-7-oracle

but it looks like server config issue.

@kallestenflo
Copy link
Copy Markdown
Contributor

Travis config is now updated to java 8.

@apatrida
Copy link
Copy Markdown

This could actually not throw an exception at all since the configuration is known in the EvaluationContextImpl and so a null or empty list could be returned, which would then be handled in the calling layer correctly as well as it does in the catch block. Even a no stack trace version of the exception takes time. Or, if you are throwing a new stack trace version, make a static instance of the exception and do not create a new one each time.

@apatrida
Copy link
Copy Markdown

I added a patch to the other issue which should be faster performance than this item, assuming I didn't miss a case and that test coverage is good to show this doesn't break anything in the different permutations of the configuration.

#456 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants