serial: eliminate implicit xml namespace for exclusive c14n#5
Open
williamareynolds wants to merge 1 commit intojonwiggins:mainfrom
Open
serial: eliminate implicit xml namespace for exclusive c14n#5williamareynolds wants to merge 1 commit intojonwiggins:mainfrom
williamareynolds wants to merge 1 commit intojonwiggins:mainfrom
Conversation
70475b5 to
d923dff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I was working on integrating xml oxide into a library I'm building at work. When running the Exclusive C14N tests
I was having issues with xmlns:xml being emitted in cannonicalized output. This change just prevents that being written out by seeding the namespace stack with the xml namespace.
Type of Change
Spec Reference
And by extension:
Test Plan
xmllintChecklist
cargo fmt --all)cargo clippy --all-targets --all-features -- -D warnings)cargo test --all-features)<module>: <summary>convention