Add vrfRef to BGP and propagate VRF through BGPPeer controller#302
Merged
felix-kaestner merged 1 commit intomainfrom Apr 28, 2026
Merged
Add vrfRef to BGP and propagate VRF through BGPPeer controller#302felix-kaestner merged 1 commit intomainfrom
felix-kaestner merged 1 commit intomainfrom
Conversation
hardikdr
added
the
area/switch-automation
felix-kaestner
force-pushed
the
bgpref
branch
4 times, most recently
from
e39bf7c to
7f07bd4
Compare
felix-kaestner
force-pushed
the
vrfref
branch
3 times, most recently
from
9469b2a to
efa352e
Compare
nikatza
reviewed
Apr 22, 2026
swagner-de
reviewed
Apr 23, 2026
Contributor
swagner-de
left a comment
swagner-de
left a comment
There was a problem hiding this comment.
Shouldn't we check here, that the BGPs VRF is empty? Otherwise we would delete the BGP process whenever we delete a VRFs BGP?
swagner-de
requested changes
Apr 23, 2026
Contributor
Author
|
@swagner-de I've update the deletion procedure with the following changes:
|
swagner-de
approved these changes
Apr 28, 2026
BGP.Spec gains an optional VrfRef field that scopes the BGP instance to a VRF. Both the BGP and BGPPeer controllers resolve this reference and pass the VRF to all provider calls. The BGPPeer controller gains a reconcileVRF helper that resolves BGP.Spec.VrfRef and sets ConfiguredCondition on failure; it returns nil when unset so the provider uses the default VRF. A vrfToBGPPeers mapper and VRF watcher (create/delete only) enqueue affected peers when their BGP's VRF definition changes. The BGP watcher predicate is extended to trigger on any ready state change and when VrfRef changes.
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BGP.Spec gains an optional VrfRef field that scopes the BGP instance to a VRF. Both the BGP and BGPPeer controllers resolve this reference and pass the VRF to all provider calls.
The BGPPeer controller gains a reconcileVRF helper that resolves BGP.Spec.VrfRef and sets ConfiguredCondition on failure; it returns nil when unset so the provider uses the default VRF.
A vrfToBGPPeers mapper and VRF watcher (create/delete only) enqueue affected peers when their BGP's VRF definition changes. The BGP watcher predicate is extended to trigger on any ready state change and when VrfRef changes.