Additional options for rolling ball background subtraction#143
Additional options for rolling ball background subtraction#143lguerard wants to merge 9 commits intoimcf:develfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #143 +/- ##
====================================
+ Coverage 30% 33% +3%
====================================
Files 25 25
Lines 1763 1799 +36
====================================
+ Hits 527 589 +62
+ Misses 1236 1210 -26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lguerard
force-pushed
the
rollingball_options
branch
from
d33a0a6 to
cd48fac
Compare
ehrenfeu
changed the title
ehrenfeu
added
enhancement
|
Please add test 🧪 coverage 🕵🏼 - I've started a basic one in 373a05c but since this is just about generating strings and calling macro commands, we should be able to reach full 🚀 coverage. |
| options = ( | ||
| "sigma=" | ||
| if filter_method == "Gaussian Blur" | ||
| else "radius=" + str(filter_radius) + " stack" | ||
| ) |
There was a problem hiding this comment.
This is much harder to read compared to this (which is 3 lines vs. 5 lines):
options = "sigma"
if filter_method != "Gaussian Blur":
options = "radius=" + str(filter_radius) + " stack"| def filter_options(filter_method, filter_radius, do_3d=False): | ||
| """Build the ImageJ filter command and options strings.""" | ||
|
|
There was a problem hiding this comment.
Docstring is missing parameters description (simply copy the relevant parts from the apply_filter() function).
Actually the ruff linter should complain about this but we need to wait until ruff-pr-21076 has been merged (cf. #148) ... ⏳
| imp : ij.ImagePlus | ||
| Input ImagePlus to filter and threshold | ||
| threshold_method : str | ||
| Name of the threshold method to use | ||
| do_3d : bool, optional | ||
| If set to True, the automatic threshold will be done on a 3D stack, by default True |
There was a problem hiding this comment.
Please adhere to the docstring conventions (line length, full stop). 😳
(There's a bunch of those in this file).
|
|
||
| def threshold_options(threshold_method, do_3d=True): | ||
| """Build the ImageJ threshold option strings.""" | ||
|
|
There was a problem hiding this comment.
Docstring is missing parameters description (simply copy the relevant parts from the apply_filter() function).
Actually the ruff linter should complain about this but we need to wait until ruff-pr-21076 has been merged (cf. #148) ... ⏳
2 participants
feat: Enhance rolling ball background subtraction with additional opt…
…ions