Skip to content

fix: origin token#25

Merged
priom merged 1 commit intoprodfrom
hotfix
Apr 30, 2026
Merged

fix: origin token#25
priom merged 1 commit intoprodfrom
hotfix

Conversation

@priom
Copy link
Copy Markdown
Member

@priom priom commented Apr 30, 2026

No description provided.

@priom priom merged commit b1b51ba into prod Apr 30, 2026
3 checks passed
@priom priom deleted the hotfix branch April 30, 2026 19:33
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the POPULAR_SYMBOLS set in the across-bridge-modal.tsx component to only include "USDC". Feedback suggests expanding this set to include "USDC.e" to ensure compatibility with bridged USDC variants on networks like Polygon and Arbitrum, preventing potential filtering issues for users.


// const POPULAR_SYMBOLS = new Set(["USDC", "USDT", "USDT0", "ETH", "WETH", "WBTC", "DAI", "cbBTC"]);
const POPULAR_SYMBOLS = new Set(["USDT", "USDT0"]);
const POPULAR_SYMBOLS = new Set(["USDC"]);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Restricting the popular symbols to only "USDC" might be too narrow for chains like Polygon and Arbitrum, where the bridged version of USDC (often symbolized as "USDC.e") is still commonly used. If the Across SDK returns the bridged variant for these chains, it will be filtered out by the logic on line 123, potentially leaving the user with no selectable tokens in the modal. Consider including "USDC.e" in the set to ensure better compatibility and a smoother user experience across all supported networks.

Suggested change
const POPULAR_SYMBOLS = new Set(["USDC"]);
const POPULAR_SYMBOLS = new Set(["USDC", "USDC.e"]);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant