Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the POPULAR_SYMBOLS set in the across-bridge-modal.tsx component to only include "USDC". Feedback suggests expanding this set to include "USDC.e" to ensure compatibility with bridged USDC variants on networks like Polygon and Arbitrum, preventing potential filtering issues for users.
|
|
||
| // const POPULAR_SYMBOLS = new Set(["USDC", "USDT", "USDT0", "ETH", "WETH", "WBTC", "DAI", "cbBTC"]); | ||
| const POPULAR_SYMBOLS = new Set(["USDT", "USDT0"]); | ||
| const POPULAR_SYMBOLS = new Set(["USDC"]); |
There was a problem hiding this comment.
Restricting the popular symbols to only "USDC" might be too narrow for chains like Polygon and Arbitrum, where the bridged version of USDC (often symbolized as "USDC.e") is still commonly used. If the Across SDK returns the bridged variant for these chains, it will be filtered out by the logic on line 123, potentially leaving the user with no selectable tokens in the modal. Consider including "USDC.e" in the set to ensure better compatibility and a smoother user experience across all supported networks.
| const POPULAR_SYMBOLS = new Set(["USDC"]); | |
| const POPULAR_SYMBOLS = new Set(["USDC", "USDC.e"]); |
No description provided.