Ipset bootstrap#7
Open
TechnologyClassroom wants to merge 7 commits intohackman:masterfrom
Open
Conversation
first pass; this does nothing to "clean-up", for example if block_type is first set to ipset and then later changed the created ipset is abandoned and must be removed manually. I included a bunch of comments but maybe those should be removed to better match the tighter style of the rest of the program.
implement ipset bootstrapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch to
fortress.plsolves #5 and was a collaboration with @mplscorwin and myself.I wrote a generic installer file that should work for most Debian and Red Hat based systems without the need to install from a package.
While I was tinkering with the package, I made some other changes that are listed below.
README.mdfile and wrapped lines at 80 characters.my.txtlist.TODO.mdfile and filed issues for all of those feature requests. I made a few feature requests that I noticed as well.shellcheckon the *.sh files and put more variables in double-quotes.I did not use generative AI. These code commits were written on a terminal by a human.
Edit: Added shellcheck commit and description.
Edit: GitHub does not really give the user making a pull request a clean preview of what all is being included in a pull request before making one. Sorry! If you want me to clean these up and resubmit as smaller discrete patches I can. Doing all of that without hearing from you would just be a bunch of noise at this point though. We are planning on using this on some production servers that are seeing SYN floods. I really appreciate your project.
Edit 2: This does not work yet. We're fixing.
Edit 3: This patch now works, but now I am not sure that reading from
/proc/net/tcpis a method that works for this anymore.Edit 4: I closed my other pull request and copied the text to this one since they are also included in this one. I can still separated it out into small parts if you want.