Checkout backend actions#56
Open
thomasballarddev wants to merge 2 commits into
Open
Conversation
RenaudBernier
changed the title
achneerov
reviewed
Apr 20, 2026
Comment on lines
+14
to
+20
| async function getDefaultPriceId(stripeProductId: string) { | ||
| const product = await stripe.products.retrieve(stripeProductId); | ||
| const defaultPrice = product.default_price; | ||
| if (typeof defaultPrice === "string") return defaultPrice; | ||
| return (defaultPrice as Stripe.Price | null)?.id ?? null; | ||
| } | ||
|
|
There was a problem hiding this comment.
Should actions.ts only be for writes and maybe have a dedicated queries.ts for reads? also maybe we can use this instead?
achneerov
reviewed
Apr 20, 2026
Comment on lines
+62
to
+64
| const service = await db.query.services.findFirst({ | ||
| where: eq(services.id, serviceId), | ||
| }); |
There was a problem hiding this comment.
achneerov
reviewed
Apr 20, 2026
Comment on lines
+123
to
+125
| const service = await db.query.services.findFirst({ | ||
| where: eq(services.id, row.serviceId), | ||
| }); |
|
Honestly I would wait until this PR is merged #55, feels like life would be easier, then rebase onto dev |
thomasballarddev
force-pushed
the
feature/49-backend-actions
branch
from
cac31f8 to
06b0440
Compare
…is branch (services enum, title, description, price, isactive, stripe product id, status). Added relationship of coach id to profile (will discuss). added stripeorderid to servicebookings. stripeorderid to coaching services.
thomasballarddev
force-pushed
the
feature/49-backend-actions
branch
from
06b0440 to
777721d
Compare
thomasballarddev
changed the title
martin0024
requested changes
May 14, 2026
Contributor
martin0024
left a comment
martin0024
left a comment
There was a problem hiding this comment.
Good job thomas.
One concern:
Stripe retries checkout.session.completed regularly imagine if a later state (refund, cancellation) has already moved the row, a retry will re-flip it to confirmed or pending. Scope the update with and(eq(id,…), eq(status, 'awaiting_payment')) please.
Comment on lines
+14
to
+19
| async function getDefaultPriceId(stripeProductId: string) { | ||
| const product = await stripe.products.retrieve(stripeProductId); | ||
| const defaultPrice = product.default_price; | ||
| if (typeof defaultPrice === "string") return defaultPrice; | ||
| return (defaultPrice as Stripe.Price | null)?.id ?? null; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| async function getDefaultPriceId(stripeProductId: string) { | |
| const product = await stripe.products.retrieve(stripeProductId); | |
| const defaultPrice = product.default_price; | |
| if (typeof defaultPrice === "string") return defaultPrice; | |
| return (defaultPrice as Stripe.Price | null)?.id ?? null; | |
| } | |
| async function getDefaultPriceId(stripeProductId: string): Promise<string> { | |
| const product = await stripe.products.retrieve(stripeProductId); | |
| const defaultPriceId = product.default_price; | |
| if (!defaultPriceId) { | |
| throw new Error(`Stripe product ${stripeProductId} has no default price`); | |
| } | |
| return defaultPriceId as string; | |
| } |
| params.userId, | ||
| params.email, | ||
| ); | ||
| const origin = (await headers()).get("origin") ?? ""; |
Contributor
There was a problem hiding this comment.
Suggested change
| const origin = (await headers()).get("origin") ?? ""; | |
| const origin = getRequestOrigin(); |
function getRequestOrigin(): string {
const origin = headers().get("origin");
if (!origin) {
throw new Error("Missing request origin");
}
return origin;
}
Contributor
There was a problem hiding this comment.
A row is inserted with awaiting_payment before the Stripe call. Abandoned checkouts leave permanent orphan rows.
Why does checkoutServiceBooking deletes the booking row if Stripe fails but checkoutCoachingSession does not?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49
Overview
Implements the backend actions for checking out coaching sessions (private lessons) and service bookings (programs).
Testing
Manual
Checklist
Tip: You can make the issue and then check them after the fact or replace
[ ]with[x]to check it!Notes
{Any issues/suggestions relating to the ticket, repo, assignments, TL duties; please mention here!}