fix: replace bare except with except Exception in v1.py#487
Open
harshadkhetpal wants to merge 1 commit intoglobocom:masterfrom
Open
fix: replace bare except with except Exception in v1.py#487harshadkhetpal wants to merge 1 commit intoglobocom:masterfrom
harshadkhetpal wants to merge 1 commit intoglobocom:masterfrom
Conversation
Replace bare `except:` with `except Exception:` in _load_template_file (line 597). Bare `except:` catches all exceptions including SystemExit, KeyboardInterrupt, and GeneratorExit, which can mask critical errors and make debugging harder (PEP 8 E722). Since this block handles a fallback case without re-raising the original exception, `except Exception:` is the correct narrower alternative. No behavioral change for normal operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace bare
except:withexcept Exception:in _load_template_file (line 597).Bare
except:catches all exceptions including SystemExit, KeyboardInterrupt, and GeneratorExit, which can mask critical errors and make debugging harder (PEP 8 E722).Since this block handles a fallback case without re-raising the original exception,
except Exception:is the correct narrower alternative. No behavioral change for normal operation.