-
Notifications
You must be signed in to change notification settings - Fork 7.5k
feat: implement preset wrap strategy #2189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kennedy-whytech
wants to merge
6
commits into
github:main
Choose a base branch
from
kennedy-whytech:kennedy-whytech-feat-preset-wrap-strategy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bb67923
feat: implement strategy: wrap for _register_skills — substitute {COR…
kennedy-whytech 864c440
feat: wire strategy: wrap into register_commands — substitute {CORE_T…
kennedy-whytech df00038
test: end-to-end wrap strategy coverage via self-test preset
kennedy-whytech 6a24268
docs: mark strategy: wrap as implemented for command templates
kennedy-whytech 53220f8
fix: resolve core template from package bundle, not project .specify dir
kennedy-whytech 4fe7f81
fix: inherit core scripts in wrap strategy and resolve extension comm…
kennedy-whytech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| description: "Self-test wrap command — pre/post around core" | ||
| strategy: wrap | ||
| --- | ||
|
|
||
| ## Preset Pre-Logic | ||
|
|
||
| preset:self-test wrap-pre | ||
|
|
||
| {CORE_TEMPLATE} | ||
|
|
||
| ## Preset Post-Logic | ||
|
|
||
| preset:self-test wrap-post |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
strategy: wrapis used here,_substitute_core_templatereturns the wrapped core template’s frontmatter as the second tuple element, but it’s discarded. For SKILL-target agents that callresolve_skill_placeholders(e.g. codex/kimi), any{SCRIPT}/{AGENT_SCRIPT}placeholders coming from the substituted core body will remain unresolved unlessscripts/agent_scriptsare inherited intofrontmatter(similar to what_register_skillsnow does). Consider mergingscriptsandagent_scriptsfrom the core frontmatter when the preset frontmatter doesn’t define them, before_adjust_script_pathsruns so paths get normalized too.