C++: Upgrade cpp/suspicious-add-sizeof to high precision#21635
Merged
geoffw0 merged 5 commits intogithub:mainfrom Apr 14, 2026
Merged
C++: Upgrade cpp/suspicious-add-sizeof to high precision#21635geoffw0 merged 5 commits intogithub:mainfrom
geoffw0 merged 5 commits intogithub:mainfrom
Conversation
Contributor
Author
|
We now have a successful DCA run (and QA data) for this change as well, LGTM. |
jketema
approved these changes
Apr 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the C++ CodeQL query cpp/suspicious-add-sizeof to @precision high so it can run in the default code scanning suite.
Changes:
- Updated query metadata to mark
cpp/suspicious-add-sizeofas@precision high. - Added a change note documenting the precision upgrade.
- Updated the code scanning suite integration-test expectation to include the query.
Show a summary per file
| File | Description |
|---|---|
| cpp/ql/src/change-notes/2026-04-02-suspicious-add-sizeof.md | Documents the precision upgrade and default-suite inclusion. |
| cpp/ql/src/Security/CWE/CWE-468/SuspiciousAddWithSizeof.ql | Changes query metadata from medium to high precision. |
| cpp/ql/integration-tests/query-suite/cpp-code-scanning.qls.expected | Updates expected resolved suite contents to include the query. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
Contributor
Author
|
Thanks for the lightning fast approval! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade
cpp/suspicious-add-sizeofto@precision high(following improvement and multiple rounds of testing).