ci: Restore changelog-preview workflow with hardened craft 2.26.2#6056
Open
ci: Restore changelog-preview workflow with hardened craft 2.26.2#6056
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 143787a. Configure here.
The reusable workflow only references secrets.GITHUB_TOKEN, which is auto-provisioned per job. Inheriting all repo secrets under pull_request_target is unnecessary exposure. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Re-adds
.github/workflows/changelog-preview.yml, removed in #6030, using the hardened reusable workflow fromgetsentry/craft@v2.26.2(#6050).Differences from the previously deleted file:
3dc647fee3586e57c7c31eb900fdec7cbb44f23f(v2.26.2) instead of v2.25.4.permissions.contents: write→contents: read. Upstream's reusable workflow only reads git metadata +.craft.yml; write was unnecessary and unsafe underpull_request_target.statuses: write(only needed in non-comment / status-check mode; we use the default comment mode).unlabeledto the trigger types per upstream's recommended caller template.💡 Motivation and Context
The original workflow combined
pull_request_target+contents: write+secrets: inheritwhile pinning to a craft version (v2.25.4) that predated the upstream hardening series (2.25.5 onward). PR #6030 removed it. Now that #6050 has landed bumping the release workflow to craft 2.26.2, we can safely restore the changelog preview using the redesigned upstream reusable workflow, which:.craft.yml,persist-credentials: false.Refs:
getsentry/craft/.github/workflows/changelog-preview.yml💚 How did you test it?
Workflow file only — will be exercised by GitHub once this PR is opened (the workflow runs on
pull_request_target, so the version on the base branch is what executes; full validation will come once merged).📝 Checklist
sendDefaultPIIis enabled🔮 Next steps