fix(grpc): add isolation_scope to async server interceptor#5940
fix(grpc): add isolation_scope to async server interceptor#5940alexander-alderman-webb merged 2 commits intogetsentry:masterfrom
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
|
Thanks for opening this PR @robinvd !
I'm not seeing the test mentioned in your description in this change set - was it potentially missed in the commit that was made? |
|
not seeing the test mentioned in your description in this change set - was it potentially missed in the commit that was made? thanks so much for checking this out @ericapisani ! i wrote the description but then never got around to the test. I can still make one if thats required! |
|
I think this clearly didn't isolate requests before and does now. I'll go ahead and merge now @robinvd, thanks for the contribution! |
047a516
into
getsentry:master
Description
Fixes #5894
The async gRPC server interceptor was missing isolation_scope() wrapping, causing scope state to leak between concurrent requests. The sync interceptor already had this. This PR adds the missing isolation scope to the async unary_unary handler and adds a test proving request isolation.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)