Skip to content

fix(browser): filter implausible LCP values#20338

Draft
logaretm wants to merge 1 commit intodevelopfrom
feat/lcp-plausibility-filter
Draft

fix(browser): filter implausible LCP values#20338
logaretm wants to merge 1 commit intodevelopfrom
feat/lcp-plausibility-filter

Conversation

@logaretm
Copy link
Copy Markdown
Member

Summary

  • add an LCP plausibility guard to drop implausible browser-reported values above 60 seconds
  • apply the guard to both pageload LCP measurements and standalone LCP spans
  • add focused unit tests for valid and invalid LCP values

Testing

  • yarn test:unit test/metrics/lcp.test.ts test/metrics/inpt.test.ts
  • yarn lint packages/browser-utils/src/metrics/lcp.ts packages/browser-utils/src/metrics/browserMetrics.ts packages/browser-utils/test/metrics/lcp.test.ts

Co-Authored-By: GPT-5 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 25.78 kB - -
@sentry/browser - with treeshaking flags 24.27 kB - -
@sentry/browser (incl. Tracing) 42.81 kB +0.1% +42 B 🔺
@sentry/browser (incl. Tracing, Profiling) 47.43 kB +0.07% +33 B 🔺
@sentry/browser (incl. Tracing, Replay) 81.71 kB +0.04% +25 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 71.25 kB +0.05% +34 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 86.42 kB +0.03% +22 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 98.63 kB +0.04% +34 B 🔺
@sentry/browser (incl. Feedback) 42.59 kB - -
@sentry/browser (incl. sendFeedback) 30.45 kB - -
@sentry/browser (incl. FeedbackAsync) 35.45 kB - -
@sentry/browser (incl. Metrics) 27.07 kB - -
@sentry/browser (incl. Logs) 27.2 kB - -
@sentry/browser (incl. Metrics & Logs) 27.89 kB - -
@sentry/react 27.53 kB - -
@sentry/react (incl. Tracing) 45.13 kB +0.09% +38 B 🔺
@sentry/vue 30.61 kB - -
@sentry/vue (incl. Tracing) 44.66 kB +0.09% +38 B 🔺
@sentry/svelte 25.8 kB - -
CDN Bundle 28.46 kB - -
CDN Bundle (incl. Tracing) 43.86 kB +0.1% +42 B 🔺
CDN Bundle (incl. Logs, Metrics) 29.83 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 44.93 kB +0.08% +33 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 68.73 kB - -
CDN Bundle (incl. Tracing, Replay) 80.81 kB +0.04% +26 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 81.86 kB +0.04% +29 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 86.35 kB +0.05% +42 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 87.37 kB +0.03% +25 B 🔺
CDN Bundle - uncompressed 83.12 kB - -
⛔️ CDN Bundle (incl. Tracing) - uncompressed (max: 130 kB) 130.03 kB +0.07% +87 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 87.27 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 133.45 kB +0.07% +87 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 210.63 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 247.29 kB +0.04% +87 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 250.69 kB +0.04% +87 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 260.21 kB +0.04% +87 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 263.59 kB +0.04% +87 B 🔺
@sentry/nextjs (client) 47.57 kB +0.1% +43 B 🔺
@sentry/sveltekit (client) 43.29 kB +0.11% +46 B 🔺
@sentry/node-core 57.94 kB +0.02% +6 B 🔺
@sentry/node 174.78 kB +0.01% +7 B 🔺
@sentry/node - without tracing 97.89 kB +0.03% +21 B 🔺
@sentry/aws-serverless 115.12 kB +0.01% +8 B 🔺

View base workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant