Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
StakingLens.getDelegations()into an explicit hybrid scan path0..255for active validators and Gem Wallet's curated validators0..7scanning for validator-set fallback validatorsMAX_DELEGATIONSsrc/monad/README.mddocumenting the trade-off and accepted blind spotWhy
Monad withdrawal ids are scoped per
(validator, delegator)and may use the full0..255range. The previous lens only scanned0..7, which could miss valid withdrawals. After adding the deeper scan, the next risk was ordering: curated validators could still be squeezed out when a user had enough active delegations to hitMAX_DELEGATIONS.This change keeps the common Gem Wallet path accurate without paying the cost of a full
all validators x 256 withdraw idssweep on every call.Impact
getDelegations(address)withdrawId > 7remain an intentional blind spot, now documentedValidation
forge fmt src/monad/StakingLens.sol test/monad/StakingLens.t.solforge lint src/monad/StakingLens.sol test/monad/StakingLens.t.solforge test --match-path test/monad/StakingLens.t.sol