fix(reply): use send-as envelope

[FromSi]

What?

Updates the SMTP envelope sender for outgoing mail.

Matcha now uses send_as_email for MAIL FROM when it is configured. If it is not configured, it keeps the existing fallback behavior.

This applies to regular email sending and calendar replies.

Why?

Closes #1274

Previously, MAIL FROM was based on fetch_email, with account.email as the fallback.

Now the order is:

send_as_email -> fetch_email -> account.email

fetch_email is used to match incoming messages to an account. For outgoing mail, the configured Send-As address should be used first.

[andrinoff]

This is an impossible situation, where FetchEmail does not have the right to send on behalf of EmailAddress (or should be impossible)

EmailAddress, on the other hand can be not an email. This is why it is using FetchEmail

#448, change made in #449

[andrinoff]

@FromSi please, change this PR, to send the envelope at first from Send-as address, if set, otherwise, fall back to FetchEmail (which will never be empty, so no need to fall back to EmailAddress

[FromSi]

@andrinoff I updated the SMTP envelope sender to use GetSendAsEmail(), so MAIL FROM now uses the configured send-as address first and falls back through the existing fetch-email behavior.

Is this what you had in mind?

Also, should I remove the “Closes #...” text from the PR description?

[andrinoff]

Yes, that's what I had in mind, thank you.

No, don't remove it, it's still the fix for this.

[andrinoff]

/build

[floatpanebot]

Build complete (ca79b63)

Warning

This is an unreviewed PR build and has not been security audited. It may contain bugs, vulnerabilities, or malicious code. Do not use for daily use. Only use for testing purposes.

OS	Arch	Download
Linux	amd64	matcha_preview_linux_amd64.tar.gz
Linux	arm64	matcha_preview_linux_arm64.tar.gz
macOS	amd64	matcha_preview_darwin_amd64.tar.gz
macOS	arm64	matcha_preview_darwin_arm64.tar.gz
Windows	amd64	matcha_preview_windows_amd64.zip
Windows	arm64	matcha_preview_windows_arm64.zip

[andrinoff]

the issue creator doesn't seem to respond. I'll merge either way

[andrinoff]

lgtm now

[andrinoff]

@FromSi can you change the PR description?

[FromSi]

@andrinoff the title and description have been updated

[andrinoff]

@andrinoff the title and description have been updated

@FromSi , I think @LeaWhoCodes emailed you and invited to the org