Update AndroidManifest.xml<?xml version="1.0" encoding="utf-8"?> <man…#681
Update AndroidManifest.xml<?xml version="1.0" encoding="utf-8"?> <man…#681johnhixson372-debug wants to merge 2 commits intofirebase:masterfrom
Conversation
…ifest xmlns:android="http://schemas.android.com/apk/res/android"> <application android:allowBackup="true" android:icon="@mipmap/ic_launcher" android:label="@string/app_name" android:supportsRtl="true" android:theme="@style/AppTheme"> <!-- [START fcm_disable_auto_init] --> <meta-data android:name="firebase_messaging_auto_init_enabled" android:value="false" /> <meta-data android:name="firebase_analytics_collection_enabled" android:value="false" /> <!-- [END fcm_disable_auto_init] --> <activity android:name=".MainActivity" android:exported="true"> <intent-filter> <action android:name="android.intent.action.MAIN" /> <category android:name="android.intent.category.LAUNCHER" /> </intent-filter> </activity> <activity android:name=".kotlin.MainActivity" /> </application> </manifest>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Android manifest to disable application backups by setting android:allowBackup to false. The review feedback correctly identifies that for devices running Android 12 or later, this attribute is ignored during device-to-device transfers, and recommends implementing android:dataExtractionRules to provide more granular and effective data protection.
|
|
||
| <application | ||
| android:allowBackup="true" | ||
| android:allowBackup="false" |
There was a problem hiding this comment.
Starting with Android 12 (API level 31), the android:allowBackup="false" attribute is ignored for device-to-device (D2D) transfers. To ensure that application data is not transferred or backed up on modern Android versions, you should also implement android:dataExtractionRules in the <application> tag. This provides more granular control over what data is included in backups and transfers, which is especially important for apps handling sensitive messaging data.
1 participant
…ifest xmlns:android="http://schemas.android.com/apk/res/android">