Auto-update dependencies.#678
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Android Gradle Plugin (AGP) version from 9.2.0 to 9.2.1 across the entire repository, including the version catalog and numerous build.gradle.kts files. Feedback focuses on improving maintainability by refactoring the project to use the Gradle Version Catalog globally, specifically suggesting the use of the alias syntax to avoid hardcoding version strings in multiple locations.
| @@ -1,5 +1,5 @@ | |||
| [versions] | |||
| agp = "9.2.0" | |||
| agp = "9.2.1" | |||
There was a problem hiding this comment.
The Android Gradle Plugin version is being updated here, but it remains hardcoded in over 20 build.gradle.kts files across the repository. To improve maintainability and ensure that future updates only need to be made in one place, consider refactoring the project to use the Version Catalog globally (e.g., by converting subdirectories into proper Gradle subprojects or using shared build logic).
| plugins { | ||
| id("com.android.application") version "9.2.0" apply false | ||
| id("com.android.library") version "9.2.0" apply false | ||
| id("com.android.application") version "9.2.1" apply false |
There was a problem hiding this comment.
The root build.gradle.kts already uses a Version Catalog for other plugins. Since androidApplication is defined in gradle/libs.versions.toml, you should use the alias syntax here to avoid hardcoding the version string and maintain consistency with plugins like composeCompiler. Additionally, consider adding the com.android.library plugin to the catalog to allow using an alias for it as well.
alias(libs.plugins.androidApplication) apply false
2 participants
Brought to you by your friendly Repository Gardener.