Variable length quantity#995
Open
A-O-Emmanuel wants to merge 5 commits into
Open
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the PHP track implementation of variable-length-quantity to bring it fully in line with the current canonical data from problem-specifications.
✅ Summary of Changes
Updated exercise metadata using:
configlet sync -u -e variable-length-quantity --yes --docs --filepaths --metadata --tests include
Ensured Markdown instructions and .meta files reflect the latest canonical content.
Resolved the previously unsynced instructions.md.
Removed unnecessary // strict_types comments from:
Test file
Example solution
Preserved the directive itself (declare(strict_types=1);) as required for PHP track consistency.
Left the comment intact in the student stub file, per track conventions.
Added missing UUIDs to test DocBlocks.
Updated all #[TestDox] annotations to match canonical descriptions exactly.
Ensured every test case corresponds 1:1 with the canonical JSON.
Renamed all test methods to reflect the full canonical description for clarity and consistency.
Ensured naming is deterministic and generator‑friendly.
Inserted variable-length-quantity alphabetically to keep the file properly ordered.
Ensures future syncs will include this exercise automatically.
Verified all test cases match canonical order.
Removed outdated patterns and ensured full alignment with current problem-specifications.
Confirmed no missing or duplicated tests.
Added my GitHub handle to .meta/config.json as a contributor to this exercise.