Skip to content

Sync series (issue #988)#991

Open
resu-xuniL wants to merge 5 commits into
exercism:mainfrom
resu-xuniL:series
Open

Sync series (issue #988)#991
resu-xuniL wants to merge 5 commits into
exercism:mainfrom
resu-xuniL:series

Conversation

@resu-xuniL
Copy link
Copy Markdown
Contributor

@resu-xuniL resu-xuniL commented Jun 1, 2026

  • Synced series metadata and docs
  • Removed strict types comments from example.php and SeriesTest.php
  • Added UUID and TestDox to tests
  • Added missing / edit tests
  • Added series to auto-sync.txt
  • Added GitHub handle to config.json

Ref: #988

Closes #988

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@resu-xuniL resu-xuniL changed the title Sync series (issue #989) Sync series (issue #988) Jun 1, 2026
Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, did I forget to say: Your AI should not phantasize but you should synchronize to the canonical repo: https://github.com/exercism/problem-specifications/blob/main/exercises/series/canonical-data.json That why it's "synchronize"...

Sorry if that was unclear. Please adjust the test data.

Comment thread exercises/practice/series/SeriesTest.php Outdated
Comment thread exercises/practice/series/SeriesTest.php Outdated
Comment thread exercises/practice/series/SeriesTest.php Outdated
Comment thread exercises/practice/series/SeriesTest.php Outdated
Comment thread exercises/practice/series/SeriesTest.php Outdated
Comment thread exercises/practice/series/SeriesTest.php Outdated
Comment thread exercises/practice/series/SeriesTest.php Outdated
Comment thread exercises/practice/series/SeriesTest.php Outdated
Comment thread exercises/practice/series/SeriesTest.php Outdated
@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Jun 2, 2026
@resu-xuniL
Copy link
Copy Markdown
Contributor Author

Hmm, did I forget to say: Your AI should not phantasize but you should synchronize to the canonical repo: https://github.com/exercism/problem-specifications/blob/main/exercises/series/canonical-data.json That why it's "synchronize"...

Sorry if that was unclear. Please adjust the test data.

Sorry about that, i didn't knew that such a file exist (canonical-data.json) and I tried to come up with my own solution (100% AI free).

Working on this now

@resu-xuniL
Copy link
Copy Markdown
Contributor Author

resu-xuniL commented Jun 2, 2026

  1. Should the error messages be implemented ?
    (I see "expected": { "error": "slice length cannot be greater than series length" } in the canonical-data.json file
  2. should the Exception::class be changed to InvalidArgumentException::class

--> It breaks the tests (if I run composer test:run -- series they are failures)

@mk-mxp
Copy link
Copy Markdown
Contributor

mk-mxp commented Jun 2, 2026

To 1.: No, it's usually better to not expect a certain message in these exercises.

To 2.: Exception was chosen a long time ago, and we should stick with it. For a new exercise InvalidArgumentException would be prefered.

And of course: No AI is totally great! That was a great deal of work then... I'm sorry I missed to give that part of the first-time contributer information.

@resu-xuniL
Copy link
Copy Markdown
Contributor Author

Ok, I drop the last commit then.
Thanks for answering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync series

2 participants