Sync series (issue #988)#991
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
mk-mxp
left a comment
There was a problem hiding this comment.
Hmm, did I forget to say: Your AI should not phantasize but you should synchronize to the canonical repo: https://github.com/exercism/problem-specifications/blob/main/exercises/series/canonical-data.json That why it's "synchronize"...
Sorry if that was unclear. Please adjust the test data.
Sorry about that, i didn't knew that such a file exist ( Working on this now |
--> It breaks the tests (if I run |
|
To 1.: No, it's usually better to not expect a certain message in these exercises. To 2.: Exception was chosen a long time ago, and we should stick with it. For a new exercise And of course: No AI is totally great! That was a great deal of work then... I'm sorry I missed to give that part of the first-time contributer information. |
|
Ok, I drop the last commit then. |
seriesmetadata and docsexample.phpandSeriesTest.phpseriestoauto-sync.txtconfig.jsonRef: #988
Closes #988