feat: replace fix with suggestions in no-duplicate-imports#445
Open
Tanujkanti4441 wants to merge 3 commits into
Open
feat: replace fix with suggestions in no-duplicate-imports#445Tanujkanti4441 wants to merge 3 commits into
no-duplicate-imports#445Tanujkanti4441 wants to merge 3 commits into
Conversation
3 tasks
DMartens
reviewed
May 13, 2026
| const importHasConditions = importNode.prelude.children.length > 1; | ||
|
|
||
| if (importHasConditions) { | ||
| importNode.prelude.children.slice(1).forEach(condition => { |
There was a problem hiding this comment.
The syntax of @import also allows specifying a layer and a supports condition (so not everything after is a condition).
Or should this be handled in a follow-up?
Contributor
Author
There was a problem hiding this comment.
This PR already includes the layer and supports conditions. I have added tests regarding this also. So, I think we can just update the word condition to something more appropriate? like modifier?
DMartens
reviewed
May 13, 2026
There was a problem hiding this comment.
We could make imports an array now instead of converting it from a set to an array for Array#some/find.
DMartens
reviewed
May 13, 2026
| loc: node.loc, | ||
| messageId: "duplicateImport", | ||
| data: { url }, | ||
| fix(fixer) { |
There was a problem hiding this comment.
As the fixer is the same for the autofix and suggestion, I think we should extract this logic to a function.
DMartens
added
the
accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
To remove the fix for duplicate imports that have conditions and apply suggestions to them.
What changes did you make? (Give an overview)
Applied suggestions to the duplicate imports instead of fix.
Now, for this code rule will propose two suggestions to remove anyone the duplicates with following messages:
For first one:
Remove duplicate @import rule with condition(s) - print.For second one:
Remove duplicate @import rule without conditions.Same for this code:
For first one:
Remove duplicate @import rule with condition(s) - print.For second one:
Remove duplicate @import rule with condition(s) - print, screen.If both duplicates have the same conditions, then the rule will apply autofix and will remove the second one. For now, the autofix only works if the conditions in both then imports are in the same order.
Should we apply the autofix if imports have same conditions but in different order as well?
Related Issues
fixes #441
Is there anything you'd like reviewers to focus on?