Skip to content

NXT-3891: Removed storybook/addon-docs for sampler#861

Open
daniel-stoian-lgp wants to merge 2 commits intodevelopfrom
feature/NXT-3891
Open

NXT-3891: Removed storybook/addon-docs for sampler#861
daniel-stoian-lgp wants to merge 2 commits intodevelopfrom
feature/NXT-3891

Conversation

@daniel-stoian-lgp
Copy link
Copy Markdown
Contributor

@daniel-stoian-lgp daniel-stoian-lgp commented Apr 20, 2026

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Scrolling in VirtualList default story was very laggy

Resolution

Removed storybook/addon-docs from sampler app as it was not directly used. This dependency was causing extra rerenders on each component update.
Removing this dependency was causing an error on story load "Cannot read properties of null (reading 'useEffect')", caused by the fact that storybook and limestone or other enact dependencies might have different React versions. This was solved by forcing a single React version in webpack configuration

Additional Considerations

Updated React, react-dom and storybook dependencies to latest version

Testing in a packed version of Storybook brings better performance. In dev mode, there are still some lags.

Links

NXT-3891

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.12%. Comparing base (5d8b27f) to head (459899f).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #861      +/-   ##
===========================================
+ Coverage    85.06%   85.12%   +0.05%     
===========================================
  Files          118      118              
  Lines         4493     4523      +30     
  Branches      1226     1235       +9     
===========================================
+ Hits          3822     3850      +28     
- Misses         518      520       +2     
  Partials       153      153              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants