NXT-3891: Removed storybook/addon-docs for sampler#861
Open
daniel-stoian-lgp wants to merge 2 commits intodevelopfrom
Open
NXT-3891: Removed storybook/addon-docs for sampler#861daniel-stoian-lgp wants to merge 2 commits intodevelopfrom
daniel-stoian-lgp wants to merge 2 commits intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #861 +/- ##
===========================================
+ Coverage 85.06% 85.12% +0.05%
===========================================
Files 118 118
Lines 4493 4523 +30
Branches 1226 1235 +9
===========================================
+ Hits 3822 3850 +28
- Misses 518 520 +2
Partials 153 153 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ion-andrusciac-lgp
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Scrolling in VirtualList default story was very laggy
Resolution
Removed storybook/addon-docs from sampler app as it was not directly used. This dependency was causing extra rerenders on each component update.
Removing this dependency was causing an error on story load "Cannot read properties of null (reading 'useEffect')", caused by the fact that storybook and limestone or other enact dependencies might have different React versions. This was solved by forcing a single React version in webpack configuration
Additional Considerations
Updated React, react-dom and storybook dependencies to latest version
Testing in a packed version of Storybook brings better performance. In dev mode, there are still some lags.
Links
NXT-3891
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)