fix: only concretize eic_tf on gh but don't build#268
Merged
Conversation
veprbl
approved these changes
May 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the GitHub Actions build workflow so the eic_tf environment is only concretized (Spack lock resolution + duplicate checks) on GitHub runners, avoiding the long TensorFlow build that frequently times out in GitHub CI while still validating the environment setup.
Changes:
- Update the
eic_tfGitHub Actions matrix entry to build only thebuilder_concretization_defaultDocker target instead of thefinaltarget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR changes the strategy for eic_tf to only concretize the environment on GitHub but stops it from being built on GitHub.
TensorFlow takes more than 6 hours to build on GitHub so it times out. We therefore essentially rely on already having a build in the cache, which only happens (at best) on the second time we run the job and eicweb has already populated it there.
Moreover, until #227 there is the potential for divergence in the exact conditions of the container builds between GitHub amd eicweb, so lately we don't even match the hash of TensorFlow between GitHub and eicweb anymore either. See https://github.com/eic/containers/actions/runs/25470306644 for current default branch failure.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
eic_tf has started to fail to build quite consistently on GitHub, and is tying up runners for 6 hours at a time.