Skip to content

chore: spack-1.1.1#195

Open
wdconinc wants to merge 4 commits into
masterfrom
spack-1.1.1
Open

chore: spack-1.1.1#195
wdconinc wants to merge 4 commits into
masterfrom
spack-1.1.1

Conversation

@wdconinc
Copy link
Copy Markdown
Contributor

@wdconinc wdconinc commented Mar 10, 2026

Briefly, what does this PR introduce?

This PR upgrades spack to v1.1.1, diff.

In spack v1.1.1, the silent ignoring of libcurl SSL certificate errors in CMake FetchContent operations was fixed and is now an error. In the container build, we are running without access to the CA certificates that sign the re-encrypted MITM SSL pages on US DOE nodes. Thus, this minor bugfix upgrade requires quite a bit more care than is typical.

Copilot AI review requested due to automatic review settings March 10, 2026 04:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the container toolchain’s pinned Spack version to v1.1.1 via the central version pin in spack.sh.

Changes:

  • Bump SPACK_VERSION from v1.1.0 to v1.1.1 in spack.sh.

Comment thread spack.sh

This comment was marked as resolved.

@wdconinc wdconinc enabled auto-merge (squash) March 10, 2026 04:32
Copilot AI review requested due to automatic review settings March 13, 2026 19:56

This comment was marked as resolved.

Copilot AI review requested due to automatic review settings April 1, 2026 13:14

This comment was marked as duplicate.

Copilot AI review requested due to automatic review settings April 10, 2026 03:11

This comment was marked as duplicate.

Copilot AI review requested due to automatic review settings April 29, 2026 00:25

This comment was marked as resolved.

@wdconinc wdconinc force-pushed the spack-1.1.1 branch 2 times, most recently from d7ea52d to afd56b1 Compare April 30, 2026 17:30
Copilot AI review requested due to automatic review settings April 30, 2026 17:30

This comment was marked as duplicate.

@wdconinc wdconinc force-pushed the spack-1.1.1 branch 2 times, most recently from fb9075a to e5262f1 Compare May 10, 2026 03:50
Copilot AI review requested due to automatic review settings May 10, 2026 03:50

This comment was marked as duplicate.

Copilot AI review requested due to automatic review settings May 11, 2026 23:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comment thread containers/debian/Dockerfile
Comment thread .gitlab-ci.yml
Comment thread containers/debian/Dockerfile
Copilot AI review requested due to automatic review settings May 12, 2026 19:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Comment thread containers/eic/Dockerfile Outdated
Comment thread .gitlab-ci.yml
Comment thread .gitlab-ci.yml Outdated
Copilot AI review requested due to automatic review settings May 13, 2026 18:26
wdconinc and others added 4 commits May 14, 2026 09:57
* Initial plan

* docs: update SPACK_VERSION example to v1.1.1 in spack-environment.md

Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants