Skip to content

Removed local supervision, global supervision and recovery notification#220

Open
WilliamRoebuck wants to merge 6 commits into
eclipse-score:mainfrom
etas-contrib:feature/remove-unneeded-supervision
Open

Removed local supervision, global supervision and recovery notification#220
WilliamRoebuck wants to merge 6 commits into
eclipse-score:mainfrom
etas-contrib:feature/remove-unneeded-supervision

Conversation

@WilliamRoebuck
Copy link
Copy Markdown
Contributor

@WilliamRoebuck WilliamRoebuck commented Jun 1, 2026

Closes #133

  • Removed local, global and recovery notification
  • Pass process identifier instead of pg identifier
  • Remove deadline and logical leftovers
  • Collapse checkpoint supervision into alive supervision
  • Simplify the internal config (version updated to 8.1)
  • Add Alive_UT, MonitorIfDaemon_UT, exec_error_domain_UT

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: fb0a5738-be1e-4883-9b23-126d5cb9f20d
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 1 packages loaded
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (24 packages loaded, 10 targets configured)

Analyzing: target //:license-check (83 packages loaded, 10 targets configured)

Analyzing: target //:license-check (86 packages loaded, 10 targets configured)

Analyzing: target //:license-check (137 packages loaded, 2708 targets configured)

Analyzing: target //:license-check (145 packages loaded, 5808 targets configured)

Analyzing: target //:license-check (157 packages loaded, 8092 targets configured)

Analyzing: target //:license-check (157 packages loaded, 8094 targets configured)

Analyzing: target //:license-check (158 packages loaded, 8218 targets configured)

INFO: Analyzed target //:license-check (162 packages loaded, 10232 targets configured).
[8 / 16] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local
[13 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 22.289s, Critical Path: 2.52s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

The created documentation from the pull request is available at: docu-html

@WilliamRoebuck WilliamRoebuck marked this pull request as draft June 1, 2026 09:56
@WilliamRoebuck WilliamRoebuck force-pushed the feature/remove-unneeded-supervision branch from c45ac06 to 6fc4b9e Compare June 2, 2026 10:12
@WilliamRoebuck WilliamRoebuck force-pushed the feature/remove-unneeded-supervision branch from 6fc4b9e to 5d7fd70 Compare June 2, 2026 11:27
@WilliamRoebuck WilliamRoebuck marked this pull request as ready for review June 2, 2026 12:19
@WilliamRoebuck WilliamRoebuck temporarily deployed to workflow-approval June 2, 2026 12:31 — with GitHub Actions Inactive
@WilliamRoebuck WilliamRoebuck temporarily deployed to workflow-approval June 2, 2026 12:31 — with GitHub Actions Inactive
@NicolasFussberger NicolasFussberger self-requested a review June 2, 2026 12:35

#include "score/mw/launch_manager/alive_monitor/details/timers/TimeConversion.hpp"

// LCOV_EXCL_START (slated for removal)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should mark the code with LCOV_EXCL_START / LCOV_EXCL_END.

I would prefer removing the coverage check or lowering the threshold.

The coverage calculation is broken and adding unit tests currently might actually lower the coverage as the report does not include all the code.

WilliamRoebuck and others added 4 commits June 2, 2026 15:22
* Removed local, global and recovery notification
* Pass process identifier instead of pg identifier
* Remove deadline and logical leftovers
* Collapse checkpoint supervision into alive supervision

---------

Co-authored-by: Nicolas Fußberger <nicolas.fussberger@etas.com>
@WilliamRoebuck WilliamRoebuck force-pushed the feature/remove-unneeded-supervision branch from d17ad6e to 2aa7114 Compare June 2, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Local, Global Supervision & Notification

2 participants