Removed local supervision, global supervision and recovery notification#220
Open
WilliamRoebuck wants to merge 6 commits into
Open
Removed local supervision, global supervision and recovery notification#220WilliamRoebuck wants to merge 6 commits into
WilliamRoebuck wants to merge 6 commits into
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
c45ac06 to
6fc4b9e
Compare
6fc4b9e to
5d7fd70
Compare
|
|
||
| #include "score/mw/launch_manager/alive_monitor/details/timers/TimeConversion.hpp" | ||
|
|
||
| // LCOV_EXCL_START (slated for removal) |
Contributor
There was a problem hiding this comment.
Not sure if we should mark the code with LCOV_EXCL_START / LCOV_EXCL_END.
I would prefer removing the coverage check or lowering the threshold.
The coverage calculation is broken and adding unit tests currently might actually lower the coverage as the report does not include all the code.
* Removed local, global and recovery notification * Pass process identifier instead of pg identifier * Remove deadline and logical leftovers * Collapse checkpoint supervision into alive supervision --------- Co-authored-by: Nicolas Fußberger <nicolas.fussberger@etas.com>
This reverts commit 5d7fd70.
d17ad6e to
2aa7114
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133