Add tests for examples#219
Open
VukPavicRTRK wants to merge 3 commits into
Open
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
f87c320 to
7470d7e
Compare
7470d7e to
a155751
Compare
|
The created documentation from the pull request is available at: docu-html |
MaciejKaszynski
suggested changes
Jun 1, 2026
MaciejKaszynski
approved these changes
Jun 1, 2026
Contributor
MaciejKaszynski
left a comment
There was a problem hiding this comment.
Looks good, I re-ran this 300 times to make sure the timing is correct and came across the error from #175 but otherwise works good
| """ | ||
| Objective: Verifies the example demo runs end-to-end without crashing. | ||
|
|
||
| Starts the launch manager, transitions to Running (all example apps start), then back to Startup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
//examplestestable viabazel testso that the demo setup is automatically verified, preventing silent breakage from being merged unnoticed.What Changed
examples/integration_test/- New integration test package:test_examples.py- Starts the launch manager, transitions toRunning(verifying all example apps are alive), transitions back toStartup, and cleanly shuts down via SIGTERM.lifecycle_demo_test.json- Launch manager config scoped to the test environment (/tmp/tests/examples).BUILD- Bazel build file packaging binaries viapkg_tarand wiring up theintegration_testrule.examples/README.md- Documents how to run the new integration tests.//examples:__subpackages__visibility totesting_utils,environments, and the x86_64 OCI image target to allow reuse of shared test infrastructure.Acceptance Criteria
bazel test //examples/... --config=<...>tests that the demo is working correctly.Notes on Approach
The test reuses the existing base image and
integration_testinfra fromtests/utils/environments/x86_64-linuxrather than defining a new one from scratch, as suggested in the issue. Binaries are packaged into apkg_tararchive and deployed to the correct location, replacing the need for manual copy scripts.The smoke test in
tests/integration/smokeuses gtest APIs, so sharing test code directly wasn't practical - this test is implemented in Python using the samesetup_testfixture pattern used elsewhere in the integration test suite.How to Run
Closes #218