Skip to content

Fix Deprecated score::StringLiteral in applicationcontext.h causes build failures in downstream consumers (#214)#217

Merged
NicolasFussberger merged 4 commits into
eclipse-score:mainfrom
etas-contrib:feature/fix-deprecation-warnings
Jun 2, 2026
Merged

Fix Deprecated score::StringLiteral in applicationcontext.h causes build failures in downstream consumers (#214)#217
NicolasFussberger merged 4 commits into
eclipse-score:mainfrom
etas-contrib:feature/fix-deprecation-warnings

Conversation

@WilliamRoebuck
Copy link
Copy Markdown
Contributor

@WilliamRoebuck WilliamRoebuck commented May 28, 2026

  • Replaced score::StringLiteral with char*
  • Fixed a warning from logging a char*

Fixes #214

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 28, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: 36141373-a574-4a37-a032-886ddca78aaa
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (22 packages loaded, 10 targets configured)

Analyzing: target //:license-check (84 packages loaded, 10 targets configured)

Analyzing: target //:license-check (85 packages loaded, 10 targets configured)

Analyzing: target //:license-check (137 packages loaded, 1117 targets configured)

Analyzing: target //:license-check (149 packages loaded, 5380 targets configured)

Analyzing: target //:license-check (149 packages loaded, 5380 targets configured)

Analyzing: target //:license-check (156 packages loaded, 5835 targets configured)

Analyzing: target //:license-check (159 packages loaded, 8218 targets configured)

Analyzing: target //:license-check (161 packages loaded, 10106 targets configured)

INFO: Analyzed target //:license-check (162 packages loaded, 10232 targets configured).
[3 / 14] checking cached actions
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 23.319s, Critical Path: 2.58s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html


AasApplicationContainer::AasApplicationContainer(const std::int32_t argc,
const score::StringLiteral* argv,
const char* const* argv,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit pick, in some places there is the char* argv[], in some places its char ** argv Think we should just use the [] way

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in dd70721

@NicolasFussberger NicolasFussberger merged commit 12c2d2f into eclipse-score:main Jun 2, 2026
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecated score::StringLiteral in applicationcontext.h causes build failures in downstream consumers

3 participants