Migrate try-catch-fail patterns to assertThrows in tests#4053
Merged
akurtakov merged 1 commit intoJun 3, 2026
Conversation
Contributor
Replace legacy try { ...; fail(...); } catch (XException e) {}
patterns with JUnit 5 assertThrows().
Also fix a latent test bug: offsets[offsets.length] always threw
ArrayIndexOutOfBoundsException before getLineInformationOfOffset
was called; replaced with a properly computed out-of-bounds offset.
HeikoKlare
force-pushed
the
migrate-test-assertthrows
branch
from
cc80f33 to
7bcc033
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace legacy
try { ...; fail(...); } catch (XException e) {}patterns with JUnit 5assertThrows().Also fixes a latent test bug in
TextStoreTestandLineTrackerTest3:offsets[offsets.length]always threwArrayIndexOutOfBoundsExceptionbeforegetLineInformationOfOffsetwas called; replaced with a properly computed out-of-bounds offset.