Pin parser behaviour for !important, value lists, and at-rules#4052
Merged
vogella merged 1 commit intoJun 2, 2026
Merged
Conversation
Extend StyleSheetStructureTest with value- and at-rule-level cases that lock in the parser output the CSS engine rework's replacement parser must reproduce: !important priority, optional trailing and stray semicolons, multi-value lists, length and percentage units, unquoted @import URLs, and @media / @font-face tolerance.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends StyleSheetStructureTest with value- and at-rule-level cases that lock in the current CSS parser's output, so the engine rework's replacement parser has a behavioural gate to reproduce. New cases cover !important priority handling, optional trailing and stray semicolons, multi-value lists, length and percentage units, unquoted @import URLs, and @media / @font-face tolerance.
The assertions were pinned against the actual Batik parser output rather than assumed. All 21 tests in the class pass.