Generate .gitattributes to hide generated skills in PR diffs#80
Merged
Art Chaidarun (artnc) merged 5 commits intomasterfrom May 4, 2026
Merged
Generate .gitattributes to hide generated skills in PR diffs#80Art Chaidarun (artnc) merged 5 commits intomasterfrom
Art Chaidarun (artnc) merged 5 commits intomasterfrom
Conversation
The sync-ai-rules hook now writes a .claude/skills/.gitattributes file that marks generated_*/SKILL.md as linguist-generated, so GitHub collapses them by default in pull request diffs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Each generator now declares its own gitattributes_patterns via a base class property. The orchestrator collects patterns from all generators and writes a single root .gitattributes with a demarcated section, covering skills, AGENTS.md, and copilot-instructions.md. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Kush Agrawal (kush-duolingo)
requested review from
Art Chaidarun (artnc) and
Carter L (clevin95)
Member
There was a problem hiding this comment.
Thanks! I had mentioned .claude/.gitattributes or .claude/skills/.gitattributes as possible output files because we shouldn't clobber the repo's existing root .gitattributes, which might contain config for unrelated stuff like LFS.
Some possible options:
- Instead of overwriting the root
.gitattributes, append our config to it if absent. This seems doable but a little fragile - Use individual
.gitattributesfiles in subdirs like.claude,.cursorand.code_review. This is less invasive but also less complete sinceAGENTS.mdisn't covered. (Do we need AGENTS.md? It seems like every popular tool prefers its own custom config location? I'm not super up to date here)
Carter L (clevin95)
approved these changes
May 1, 2026
Contributor
Carter L (clevin95)
left a comment
Carter L (clevin95)
left a comment
There was a problem hiding this comment.
this is a great idea, thanks!
Addresses @artnc's review: writing a root .gitattributes would clobber existing repo config (e.g. LFS). Each multi-file generator now writes its own .gitattributes in its output directory instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
There was a problem hiding this comment.
- Good call, updated to use per-directory
.gitattributes(.claude/skills/.gitattributes) instead of overwriting the root. - Skipping
AGENTS.md/copilot-instructions.mdcoverage for now since there's no clean way to do it without touching the root.gitattributes.
Art Chaidarun (artnc)
approved these changes
May 1, 2026
Member
Art Chaidarun (artnc)
left a comment
Art Chaidarun (artnc)
left a comment
There was a problem hiding this comment.
Could also generate .github/.gitattributes to cover .github/copilot-instructions.md
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Art Chaidarun (@artnc) did we change settings for this repo recently? |
Member
|
Hmm not intentionally but maybe the old settings got terraformed away |
Member
|
Released in 1.15.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SkillsGeneratornow writes.claude/skills/.gitattributesmarkinggenerated_*/SKILL.mdaslinguist-generated.gitattributesto avoid clobbering the repo's root.gitattributes(e.g. LFS config)Verification steps
make testpassessync-ai-ruleson a repo with.cursor/rules/and confirm.claude/skills/.gitattributesis created