Skip to content

Update sim evm defi-positions route to /v1/evm/defi/positions#51

Merged
ivpusic merged 1 commit intomainfrom
gro-228-defi-positions-v1-route
Apr 20, 2026
Merged

Update sim evm defi-positions route to /v1/evm/defi/positions#51
ivpusic merged 1 commit intomainfrom
gro-228-defi-positions-v1-route

Conversation

@ivpusic
Copy link
Copy Markdown
Member

@ivpusic ivpusic commented Apr 20, 2026

Summary

  • Point dune sim evm defi-positions at the stable /v1/evm/defi/positions/<address> route (was /beta/evm/defi/positions/<address>).
  • Drop the "endpoint is in beta" note from the command's long help, since it's now v1.

Test plan

  • go build ./...
  • go test ./cmd/sim/...
  • Live call: go run ./cmd sim evm defi-positions 0xd8da6bf26964af9d7eed9e03e53415d37aa96045 --chain-ids 1 returns the expected positions table and aggregation summary
  • -o json output parses as expected (positions + aggregations)

GRO-228: the beta path has been promoted to v1, so point the CLI at
the stable route and drop the beta note from the command help.
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 20, 2026

PR Summary

Low Risk
Low risk CLI change that only updates the HTTP route and help text; main risk is unexpected behavioral differences between /beta and /v1 responses or availability.

Overview
Updates dune sim evm defi-positions to call the stable GET /v1/evm/defi/positions/<address> endpoint instead of the previous /beta/... route.

Removes the CLI help text note indicating the endpoint is beta, aligning command documentation with the new v1 API.

Reviewed by Cursor Bugbot for commit 69470fb. Configure here.

@ivpusic ivpusic merged commit 6abb50f into main Apr 20, 2026
3 checks passed
@ivpusic ivpusic deleted the gro-228-defi-positions-v1-route branch April 20, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants