Multiple scan XY API Change#51
Open
CSSFrancis wants to merge 11 commits intodirectelectron:mainfrom
Open
Conversation
… validation and initial delay handling
… sphinx-tabs for improved layout
…out client.stop_acquisition in test setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and bug fixes to the
deapiclient and its test suite. The most significant changes are focused on enhancing the flexibility and robustness of scan pattern handling, improving test reliability and performance, and refining property and acquisition management. Below is a summary of the most important changes, grouped by theme.Scan Pattern Handling and Client Improvements:
set_xy_arrayindeapi/client.pyto support lists of numpy arrays, handle both 2D and 3D input, ensure integer types, validate shapes, and correctly compute scan dimensions. This improves flexibility and error handling for scan pattern input.pixel_formatinget_resultto"AUTO"for better compatibility.Test Suite Reliability and Performance:
scope="session"for theclientfixture, reducing setup/teardown overhead and improving test performance.time.sleepcalls and replaced them with more robust idle-waiting logic (e.g.,wait_for_idle(client)), leading to more reliable and faster tests. [1] [2] [3]Test Coverage and Robustness:
File Saving and Loading Tests:
@pytest.mark.skip(reason="Slow and broken")to improve test suite reliability and focus on stable tests. [1] [2]libertem.apiinto the test function to avoid unnecessary imports and potential issues when the library is not available.