Conversation
Greptile SummaryReplaces the standalone
Confidence Score: 5/5Safe to merge. The deleted All previously flagged issues (stale No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant LCM as PickleLCM (bg thread)
participant App as ResourceSpyApp
participant Store as SqliteStore
participant Stream as Stream[float]
Note over App: dtop --log
App->>Store: "SqliteStore(path=db_path)"
App->>Store: start()
LCM-->>App: _on_msg(msg)
App->>App: _log_role("coordinator", coord, ts, None)
App->>App: "_log_role("worker_{id}", worker, ts, modules)"
loop each metric in LOGGED_METRICS
App->>Store: stream(name, float) [once per name]
Store-->>App: Stream[float]
App->>Stream: "append(val, ts=ts, tags=tags)"
end
Note over App: on_unmount
App->>Store: stop()
Reviews (4): Last reviewed commit: "Fix mypy" | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
There was a problem hiding this comment.
this is great, question is how do we analize this data, we have this hacky jupyter notebook thing
md-babel-py run yourfile.mdexecutes code blocks, produces
https://github.com/dimensionalOS/dimos/blob/dev/docs/capabilities/memory/plot.md
so you can build an analysis, agents are pretty good at this. idk if we should have a template file that people can run, or docs, or realtime rendererr for rerun. memory2 has structures for realtime rerun rendering in place, just didn't write it yet
on where we store,
need to merge #1996
dimos run unitree-go2-memory runs go2 that auto-records all sensors
so it would make sense for dtop also to record into the same db? can see later how
Problem
We want to plot metrics from dtop. Previously I saved the metrics to jsonl files and made a stand alone cli tool for the plotting, but a much better way is to just use memory2.
Closes DIM-XXX
Solution
Add streams for the metrics tracked by dtop and add them to a memory2 Sqlite store. By default, running dtop will not save the metrics. Pass
dtop --logto save. It will create a default db atdtop_<date and time>.ignore.db. Then use that as you would normally with memory2.Minor change: move legend for memory2 plots off of axis so data isn't covered.
Breaking Changes
dtop-plot no longer exists.
How to Test
terminal 1
dimos --replay --dtop run unitree-go2terminal 2
dtop --logContributor License Agreement