Add conventional commit checks and release branching actions#203
Add conventional commit checks and release branching actions#203gasperzgonec wants to merge 3 commits into
Conversation
| @@ -0,0 +1,18 @@ | |||
| #!/usr/bin/env bash | |||
| # Verifies github.actor is listed in CODEOWNERS (individual users only). | |||
There was a problem hiding this comment.
How hard is it to add check for github group as well? For example to have whole @devrev/airdrop here or @devrev/aidrop-admin?
There was a problem hiding this comment.
Maybe rename file to check-conflicting-versions.sh or sth like that?
| @@ -0,0 +1,42 @@ | |||
| #!/usr/bin/env bash | |||
| # Validates PR title and all commits in a pull request for conventional or release-command format. | |||
There was a problem hiding this comment.
What is expected/valid PR title and commits here? What do we actually validate?
There was a problem hiding this comment.
Please improve the filename.
There was a problem hiding this comment.
I don't think we need emergency releases. Even if it is a hotfix and needs to be delivered fast, you can always get approval from someone from the team. I propose moving the release-automation.yml here.
| Use active voice and present tense, e.g., This PR fixes ... | ||
|
|
||
| PR titles must use Conventional Commits (e.g. feat: ..., fix: ...). | ||
| Maintainer-only release commands (beta/..., release/..., patch/...) are |
There was a problem hiding this comment.
Instead of maintainer taking care of opening a PR for this, maybe automation can do this for us on workflow trigger?
| @@ -0,0 +1,12 @@ | |||
| #!/usr/bin/env sh | |||
There was a problem hiding this comment.
What is this script? New dependency only for this?
| "author": "devrev", | ||
| "license": "ISC", | ||
| "devDependencies": { | ||
| "@commitlint/cli": "^20.5.3", |
There was a problem hiding this comment.
Do we really need dependency for this? Another thing to resolve CVEs on.
2 participants
Description
This PR introduces new actions to match the new release workflow.
Connected Issues
Checklist
npm run testOR no tests needed.npm run test:backwards-compatibility.npm run lint.